Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop verify single RpcBlock fns #7008

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Drop verify single RpcBlock fns #7008

wants to merge 1 commit into from

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Noted that we never have to verify individual RpcBlocks for sync. Lookup sync sends the block alone always, and range sync sends chain segments.

Proposed Changes

  • Removed verify_kzg_for_rpc_block
  • Removed IntoExecutionPendingBlock impl for RpcBlock. Now lookup sync blocks use the SignedBeaconBlock IntoExecutionPendingBlock impl which is the same
  • Switched tests to import RpcBlocks with process_chain_segment

@dapplion dapplion requested a review from jxs as a code owner February 18, 2025 04:01
@michaelsproul
Copy link
Member

Should we merge this before:

?

@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress code-quality labels Feb 18, 2025
@dapplion
Copy link
Collaborator Author

Should we merge this before

Independent, I can fix conflicts later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
code-quality work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapplion @michaelsproul